Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action: run buildkite action with GH secrets #4056

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 4, 2024

What does this pull request do?

Run the Buildkite pipeline for the microbenchmarks without waiting for them.

There is no need to wait since it uses a different CI—logs can be accessed through the UI; the GitHub action will provide the link to them.

Slack notifications are delegated to the Buildkite pipeline itself.

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@v1v v1v requested review from a team June 4, 2024 10:03
@v1v v1v self-assigned this Jun 4, 2024
@david-luna
Copy link
Member

@v1v just a tiny question.

Slack notifications are delegated to the Buildkite pipeline itself.

does that mean that the action would pass always because is not waiting? so we rely on slack to get any failure notifications?

@v1v
Copy link
Member Author

v1v commented Jun 4, 2024

does that mean that the action would pass always because is not waiting?

That's correct

so we rely on slack to get any failure notifications?

The idea is to delegate the error reporting through the Buildkite pipeline, which supports Slack notifications.

ATM, the microbenchmarks are broken since a recent change in the git https cloning. I plan to fix it sooner rather than later and revisit the notifications to be smart enough to ping the right team in Slack if something goes sideways.

@v1v v1v merged commit 829f3e4 into elastic:main Jun 4, 2024
20 checks passed
@v1v v1v deleted the feature/buildkite-tokens branch June 4, 2024 17:39
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants