Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): switch to actions/attest-build-provenance #4061

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Jun 5, 2024

This had been done for other uses in this workflow in #4025,
and then this additional usage was added a bit later in #4005.

This had been done for other uses in this workflow in #4025,
and then this additional usage was added a bit later in #4005.
@trentm trentm requested a review from v1v June 5, 2024 19:44
@trentm trentm self-assigned this Jun 5, 2024
@trentm
Copy link
Member Author

trentm commented Jun 5, 2024

I noticed this old usage because the workflow run for the 4.6.0 release noted the deprecated usage:

https://github.com/elastic/apm-agent-nodejs/actions/runs/9389703649

Deprecation Notice

Please migrate from github-early-access/generate-build-provenance to actions/attest-build-provenance

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Trent! 🙏

@trentm trentm enabled auto-merge (squash) June 5, 2024 19:52
@trentm trentm merged commit 3e4768c into main Jun 5, 2024
18 checks passed
@trentm trentm deleted the trentm/use-actions-attest-build-prov branch June 5, 2024 20:07
trentm added a commit that referenced this pull request Jun 13, 2024
This had been done for other uses in this workflow in #4025,
and then this additional usage was added a bit later in #4005.
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
This had been done for other uses in this workflow in elastic#4025,
and then this additional usage was added a bit later in elastic#4005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants