Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump nyc from 15.1.0 to 17.0.0 #4067

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 10, 2024

Bumps nyc from 15.1.0 to 17.0.0.

Release notes

Sourced from nyc's releases.

nyc: v17.0.0

17.0.0 (2024-04-19)

⚠ BREAKING CHANGES

  • minimum Node version now 18

Bug Fixes

Build System

  • minimum Node version now 18 (9ef340e)
Changelog

Sourced from nyc's changelog.

17.0.0 (2024-04-19)

⚠ BREAKING CHANGES

  • minimum Node version now 18

Bug Fixes

Build System

  • minimum Node version now 18 (9ef340e)

16.0.0 (2024-04-10)

⚠ BREAKING CHANGES

  • minimum Node version now 18

Bug Fixes

Build System

  • minimum Node version now 18 (9ef340e)
Commits
  • fee2821 chore(main): release nyc 17.0.0 (#1558)
  • 10daacc build: explicitly point to config files
  • 8120112 test: remove dependency on "true" which is not on all windows sytems
  • f6e5aba chore(main): release 16.0.0 (#1554)
  • b6ed598 fix(deps): address security alerts in deps (#1555)
  • dda8e44 build: migrate to main branch (#1553)
  • 9ef340e build: move tests over to latest tapjs (#1552)
  • ab7c53b chore: Remove package-lock.json
  • 91ae8b8 chore(deps-dev): bump standard-version from 8.0.0 to 8.0.1
  • a6336e1 chore(deps): bump lodash from 4.17.15 to 4.17.19
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [nyc](https://github.com/istanbuljs/nyc) from 15.1.0 to 17.0.0.
- [Release notes](https://github.com/istanbuljs/nyc/releases)
- [Changelog](https://github.com/istanbuljs/nyc/blob/main/CHANGELOG.md)
- [Commits](istanbuljs/nyc@v15.1.0...nyc-v17.0.0)

---
updated-dependencies:
- dependency-name: nyc
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 10, 2024
@dependabot dependabot bot requested a review from a team June 10, 2024 00:28
@david-luna
Copy link
Member

david-luna commented Jun 13, 2024

% rg coverage
package.json
18:    "coverage": "COVERAGE=true ./test/script/run_tests.sh",

package-lock.json
12141:    "node_modules/istanbul-lib-coverage": {
12143:      "resolved": "https://registry.npmjs.org/istanbul-lib-coverage/-/istanbul-lib-coverage-3.2.0.tgz",
12170:        "istanbul-lib-coverage": "^3.0.0",
12194:        "istanbul-lib-coverage": "^3.0.0-alpha.1",
12291:        "istanbul-lib-coverage": "^3.0.0",
12351:        "istanbul-lib-coverage": "^3.0.0",
13941:        "istanbul-lib-coverage": "^3.0.0",
27534:    "istanbul-lib-coverage": {
27536:      "resolved": "https://registry.npmjs.org/istanbul-lib-coverage/-/istanbul-lib-coverage-3.2.0.tgz",
27557:        "istanbul-lib-coverage": "^3.0.0",
27577:        "istanbul-lib-coverage": "^3.0.0-alpha.1",
27645:        "istanbul-lib-coverage": "^3.0.0",
27689:        "istanbul-lib-coverage": "^3.0.0",
28954:        "istanbul-lib-coverage": "^3.0.0",

lib/activation-method.js
26: *    that the default of 10. Using `nyc` for coverage testing adds at least

Makefile
18:# See TESTING.md for more details on tests, TAV tests, coverage, benchmarks.

test/script/docker/run_tests.sh
22:  CMD='npm run coverage'

test/instrumentation/modules/pg/pg.test.js
795:    // for coverage of the instrumentation.

I couldn't see any place in workflows where coverage is used. That might explain why CI didn't failed although this version drops support for nodejs <18

@trentm is the CI collecting coverage in any action?

Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@trentm
Copy link
Member

trentm commented Jun 13, 2024

@trentm is the CI collecting coverage in any action?

It was dropped in #2049

@david-luna david-luna mentioned this pull request Jul 3, 2024
6 tasks
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 9, 2024

Looks like nyc is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Jul 9, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nyc-17.0.0 branch July 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants