chore: remove nyc package #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trentm I've marked as ready for review but I have some questions I'd like to discuss |
david-luna
commented
Jul 5, 2024
| @@ -175,15 +175,6 @@ jobs: | |||
| - run: npm ls --all || true | |||
| - name: npm test | |||
| run: npm test | |||
| - uses: inception-health/otel-upload-test-artifact-action@v1 | |||
There was a problem hiding this comment.
Note for reviewer: removing this will make disappear the artefacts attached to the test actions. IIUC this transforms the tests results to an OTEL trace with data in JSON format for inspection but I don't recall using it.
|
@trentm as discussed I've removed report generation to |
trentm
reviewed
Jul 5, 2024
| @@ -175,15 +175,6 @@ jobs: | |||
| - run: npm ls --all || true | |||
| - name: npm test | |||
| run: npm test | |||
| - uses: inception-health/otel-upload-test-artifact-action@v1 | |||
| @@ -7,9 +7,6 @@ | |||
| /.pnp | |||
| .pnp.js | |||
|
|
|||
| # testing | |||
| /coverage | |||
|
|
|||
There was a problem hiding this comment.
nit: Fine to remove this, but it is unrelated to the coverage tooling in the top-level package.
| @@ -192,7 +191,6 @@ | |||
| "mysql2": "^3.2.4", | |||
| "ndjson": "^2.0.0", | |||
| "numeral": "^2.0.6", | |||
| "nyc": "^15.0.0", | |||
There was a problem hiding this comment.
Can also npm uninstall tap-junit.
There was a problem hiding this comment.
done! thanks for pointing it out :)
trentm
approved these changes
Jul 8, 2024
trentm
pushed a commit
that referenced
this pull request
Jul 24, 2024
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
nycsince is not used anymore. Ref: #4067 (comment)Checklist