Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nyc package #4120

Merged
merged 5 commits into from
Jul 9, 2024
Merged

chore: remove nyc package #4120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48fc4c5
chore: remove nyc package
david-luna Jul 3, 2024
150ce51
chore: remove nyc usage in docker-test.sh
david-luna Jul 4, 2024
82d718d
chore: remove coverage generation and artifact upload
david-luna Jul 5, 2024
b7f1d3f
chore: remove unused code
david-luna Jul 5, 2024
1388471
chore: uninstall tap-junit
david-luna Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .ci/scripts/docker-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ if [[ -n ${TAV} ]]; then
npm run test:tav
# Currently the TAV tests do not support TAP or junit-formatted output.
else
rm -rf ./test_output
mkdir ./test_output
nyc node test/test.js -o ./test_output
ls test_output/*.tap | while read f; do cat $f | ./node_modules/.bin/tap-junit > $f.junit.xml; done
# rm -rf ./test_output
# mkdir ./test_output
# nyc node test/test.js -o ./test_output
# ls test_output/*.tap | while read f; do cat $f | ./node_modules/.bin/tap-junit > $f.junit.xml; done
node test/test.js
fi
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
/test-suite-output.tap

# Folders to ignore
/.nyc_output
/test_output
/build
node_modules
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fmt:
npm run lint:fix

# Prerequisite: Docker server is running.
# See TESTING.md for more details on tests, TAV tests, coverage, benchmarks.
# See TESTING.md for more details on tests, TAV tests, benchmarks.
.PHONY: test
test:
npm run test
3 changes: 0 additions & 3 deletions examples/nextjs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
/.pnp
.pnp.js

# testing
/coverage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fine to remove this, but it is unrelated to the coverage tooling in the top-level package.

# next.js
/.next/
/out/
Expand Down
3 changes: 1 addition & 2 deletions lib/activation-method.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ const CONTAINS_R_ELASTIC_APM_NODE_START =
*
* @param {Error} startStack - An Error object with a captured stack trace.
* The `stackTraceLimit` for the stack should be at least 15 -- higher
* that the default of 10. Using `nyc` for coverage testing adds at least
* one stack frame.
* that the default of 10.
* @returns {string} one of the following values:
* - "unknown"
* - "require":
Expand Down
Loading
Loading