Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump cassandra-driver from 4.7.2 to 4.8.0 #4473

Merged
merged 3 commits into from
Feb 27, 2025
Merged

chore(deps-dev): bump cassandra-driver from 4.7.2 to 4.8.0 #4473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dca678d
chore(deps-dev): bump cassandra-driver from 4.7.2 to 4.8.0
dependabot[bot] Feb 24, 2025
900c8b8
chore: update cassandra tests
david-luna Feb 25, 2025
d9935a2
fix: fix yaml file
david-luna Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .tav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,12 @@ tedious:

cassandra-driver:
# 3.1.0 is broken
versions: '>=3 <3.1.0 || >3.1.0 <5'
commands: node test/instrumentation/modules/cassandra-driver/cassandra-driver.test.js
- versions: '>=3 <3.1.0 || >3.1.0 <4.8.0'
commands: node test/instrumentation/modules/cassandra-driver/cassandra-driver.test.js
# v4.8.0 advertise a min-supported Node.js version of 18.
- versions: '>=4.8.0 <5'
Comment on lines +365 to +368
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Given this on the jira issue:

For what it’s worth support for node.js 16.x was officially removed with the 4.7.0 release in accordance with this policy. This was discussed in a message sent to the mailing list although I think we did miss the “engines” update until this release.

should we get 4.7.0 as the change point rather than 4.8.0?

node: '>=18'
commands: node test/instrumentation/modules/cassandra-driver/cassandra-driver.test.js

# Restify
# - restify <v10 doesn't work with node v18+ (https://github.com/restify/node-restify/issues/1888)
Expand Down
71 changes: 42 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 0 additions & 61 deletions test/_is_cassandra_incompat.js
View file
Open in desktop

This file was deleted.

Loading
Loading