Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR review comment command #1960

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 26, 2024

What does this pull request do?

Adds a workflow that runs the full matrix which is triggered from a PR review comment with the content /test matrix

basepi
basepi previously approved these changes Jan 26, 2024
Copy link
Member Author

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test matrix

@reakaleek reakaleek self-assigned this Jan 29, 2024
@reakaleek reakaleek requested a review from a team January 29, 2024 07:38
@reakaleek reakaleek marked this pull request as ready for review January 29, 2024 07:38
v1v
v1v previously approved these changes Jan 29, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment, otherwise LGTM

- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ inputs.ref || github.ref }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@reakaleek reakaleek requested a review from v1v January 29, 2024 08:31
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test matrix

@reakaleek reakaleek merged commit 97aaab4 into elastic:main Jan 29, 2024
579 of 583 checks passed
xrmx pushed a commit that referenced this pull request Mar 20, 2024
* Add PR review comment command

* Add to README.md

* Update .github/workflows/README.md

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

* Update .github/workflows/test.yml

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants