Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate collapsing ARN table in release notes #2071

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Automate collapsing ARN table in release notes #2071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb77e4
Automate collapsing ARN table in release notes
reakaleek Jun 25, 2024
f20f87c
Apply suggestions from code review
xrmx Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .ci/create-arn-table.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ AWS_FOLDER=${AWS_FOLDER?:No aws folder provided}
ARN_FILE=".arn-file.md"

{
echo "### Elastic APM Python agent layer ARNs"
echo "<details>"
echo "<summary>Elastic APM Python agent layer ARNs</summary>"
echo ''
echo '|Region|ARN|'
echo '|------|---|'
Expand All @@ -22,4 +23,8 @@ for f in $(ls "${AWS_FOLDER}"); do
echo "|${f}|${LAYER_VERSION_ARN}|" >> "${ARN_FILE}"
done

echo '' >> "${ARN_FILE}"
{
echo ''
echo '</details>'
echo ''
} >> "${ARN_FILE}"
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,4 @@ If you have commit access, the process is as follows:
1. After tests pass, Github Actions will automatically build and push the new release to PyPI.
1. Edit and publish the [draft Github release](https://github.com/elastic/apm-agent-python/releases)
created by Github Actions. Substitute the generated changelog with one hand written into the body of the
release and move the agent layer ARNs under a `<details>` block with a `summary`.
release.
Loading