Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #15623) ci: switch to custom setup-go action in windows #15731

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 13, 2025

Motivation/summary

windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

See actions/setup-go#495
Slightly related to #15581


This is an automatic backport of pull request #15623 done by [Mergify](https://mergify.com).

* ci: update GOCACHE vars on windows runner to improve performance

windows runner has significantly slower disks and restoring the cache is
wasting a huge amount of time

* Update ci.yml

(cherry picked from commit 211ccc8)

# Conflicts:
#	.github/workflows/ci.yml
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 13, 2025
Copy link
Contributor Author

mergify bot commented Feb 13, 2025

Cherry-pick of 211ccc8 has failed:

On branch mergify/bp/7.17/pr-15623
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 211ccc86.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@kruskall kruskall closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant