Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otel: add test for multiple Beats receivers running in the same process #43081

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

otel: add test for multiple Beats receivers running in the same process #43081

wants to merge 6 commits into from
+189 −1

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Mar 6, 2025

Proposed commit message

Libbeat has had known issues with global state in the past. Since multiple
Beats receivers can be started on the same OTel collector instance, we need
to ensure they can run in the same process without interfering with each other.

This PR adds a test confirming that two Beats receivers can start in the
same process and successfully ingest a log entry.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

$ go test -run ^TestMultipleReceivers$ ./x-pack/filebeat/fbreceiver
$ go test -run ^TestMultipleReceivers$ ./x-pack/filebeat/mbreceiver

Related issues

mauri870 added 3 commits March 6, 2025 08:57
@mauri870
otel: add test for multiple Beats receivers
bad04ec 
Libbeat has had known issues with global state in the past. Since multiple
Beats receivers can be started on the same OTel collector instance, we need
to ensure they can run in the same process without interfering with each other.

This PR adds a test confirming that two Beats receivers can start in the
same process and successfully ingest a log entry.
@mauri870
add oteltest package
7bf81c4
@mauri870
add BenchmarkFactory back, fix mbreceiver assertion
296130c
@mauri870 mauri870 added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 6, 2025
@mauri870 mauri870 self-assigned this Mar 6, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 6, 2025
@mauri870 mauri870 marked this pull request as ready for review March 6, 2025 12:38
@mauri870 mauri870 requested a review from a team as a code owner March 6, 2025 12:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 changed the title otel: add test for multiple Beats receivers otel: add test for multiple Beats receivers running in the same process Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

At least 1 approving review is required to merge this pull request.

Assignees

@mauri870 mauri870

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauri870 @elasticmachine