[8.17](backport #42966) fix(libbeat): mitigate race condition in ratelimit processor #43114
+89
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR fixes race conditions on the ratelimit processor. The race conditions can only manifest with configurations that have a global ratelimit processor and multiple inputs. Fixed by adding a mutex to the bucket struct.
During benchmarking, I also noticed an unnecessary allocation occurring in the hot path. Removing this allocation resulted in a 25% performance improvement. While locks have an inherent cost, in this scenario, the performance gain offsets that cost.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Run filebeat with a global ratelimit processor under the race detector:
This is an automatic backport of pull request #42966 done by [Mergify](https://mergify.com).