Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Fix broken mssql python integration tests #43122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faec
Copy link
Contributor

@faec faec commented Mar 7, 2025

Go 1.23 changed the handling of some TLS certificate corner cases, which breaks the certificates used in mssql test containers. This PR adds a godebug environment variable to the mssql integration tests to allow the mssql test containers to be used.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Service-Integrations Label for the Service Integrations team backport-active-all Automated backport with mergify to all the active branches labels Mar 7, 2025
@faec faec self-assigned this Mar 7, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 7, 2025
@faec faec marked this pull request as ready for review March 7, 2025 22:36
@faec faec requested a review from a team as a code owner March 7, 2025 22:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants