Add docs for running official docker image #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
navarone-feekery
commented
Sep 5, 2024
navarone-feekery
commented
- Add docs explaining how to pull and run the official docker image
- Remove docs explaining how to build Dockerfile locally
artem-shelkovnikov
approved these changes
Sep 5, 2024
|
|
||
| ```bash | ||
| $ cp config/crawler.yml.example config/crawler.yml | ||
| $ docker cp config/my-crawler.yml crawler:app/config/my-crawler.yml |
There was a problem hiding this comment.
I wonder - what is our position on copying configs vs mounting volumes?
Connectors require mounting, while crawler copying
There was a problem hiding this comment.
I hadn't considered this. Let's discuss as a team and if mounting is better we can create an issue to update docs.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
- Add docs explaining how to pull and run the official docker image - Remove docs explaining how to build Dockerfile locally
navarone-feekery
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.