Add noticefile generator and update NOTICE.txt #20
Conversation
navarone-feekery
changed the title
| @@ -0,0 +1,23 @@ | |||
| Portions copyright (c) 2010 Andre Arko | |||
There was a problem hiding this comment.
Also - do you wanna add those to gitignore?
There was a problem hiding this comment.
That makes a lot of sense actually
There was a problem hiding this comment.
@artem-shelkovnikov I've added the downloadable license files to gitignore. The manual ones are still there as otherwise anyone else running make notice would need to go find these licenses themselves.
Good question; no I did not. I'll confirm before merging. |
My understanding is that there's not a strict format, it's meant for human consumption, so a "best effort" at clarity is sufficient. Since this is the same format we've been shipping with the Enterprise Search artifacts for years, I think we're probably fine. Doesn't hurt to ask, but I wouldn't let it block you merging this. They can sometimes take a week or two to respond if they're busy. |
| @@ -0,0 +1,2459 @@ | |||
| JRuby is Copyright (c) 2007-2018 The JRuby project, and is released | |||
There was a problem hiding this comment.
What about this and other manually added licences? We're forced to keep them?
There was a problem hiding this comment.
I want them to remain because if they aren't there, every time someone wants to run make notice they will need to go and look for these files themselves and add it to this directory.
Adds a generator script that builds a NOTICE.txt file based on project dependencies.
The script will attempt to fetch SPDX license information for ruby gems. If this can't be found, it will fetch the LICENSE file directly, and failing that it will require the file to be manually added to the repository.
Run with
make notice.