Allow for full HTML extraction #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
changed the title
artem-shelkovnikov
approved these changes
Feb 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
### Closes #198 Enable full HTML extraction through a config option. The logic for this was already present in Crawler code, we were just missing two pieces: a configuration option, and to include the full HTML in the JSON to be ingested to ES. #### Changes - Add configuration `full_html_extraction_enabled` which defaults to `false` - If enabled, include the full HTML in the crawl result doc under field `full_html` - If disabled, don't include the field `full_html` at all - (Bonus) add `purge_crawl_enabled` to example YAML file as it was missing
navarone-feekery
added a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198
Enable full HTML extraction through a config option.
The logic for this was already present in Crawler code, we were just missing two pieces: a configuration option, and to include the full HTML in the JSON to be ingested to ES.
Changes
full_html_extraction_enabledwhich defaults tofalsefull_htmlfull_htmlat allpurge_crawl_enabledto example YAML file as it was missing