-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI pipeline #211
Merged
Merged
Fix CI pipeline #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efabd73.
mattnowzari
approved these changes
Feb 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Pin curl version and remove obsolete Dockerfile
navarone-feekery
added a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
1. Broken
curl
libCurl released an 8.12.0 yesterday. This is broken in Alpine Linux distros, calling
curl
with any sub command causes a crash.Resolves CI failure likely caused by recent release of curl:
2. Removal of obsolete Dockerfile
We had a second Dockerfile being used for CI testing. We should be doing this on the Dockerfile.wolfi. I've removed the old Dockerfile and changed pointers to towards Dockerfile.wolfi.