Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable for M4 users #220

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Add environment variable for M4 users #220

merged 2 commits into from
Feb 26, 2025

Conversation

meghanmurphy1
Copy link
Contributor

@meghanmurphy1 meghanmurphy1 commented Feb 26, 2025 •
edited
Loading

Add comment and environment variable to docker-compose.yml for M4 users to comment out in order to run Open Crawler

Checklists

Pre-Review Checklist

  • This PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check crawler.yml.example and elasticsearch.yml.example)
  • This PR has a meaningful title
  • This PR links to all relevant GitHub issues that it fixes or partially addresses
    • If there is no GitHub issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v0.1.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • Ran make notice if any dependencies have been added

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

@meghanmurphy1 meghanmurphy1 self-assigned this Feb 26, 2025
@meghanmurphy1 meghanmurphy1 requested a review from a team as a code owner February 26, 2025 15:07
navarone-feekery
navarone-feekery reviewed Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one edit adding more context

@meghanmurphy1 @navarone-feekery
Update docker-compose.yaml
26b82e4 
Co-authored-by: Navarone Feekery <13634519+navarone-feekery@users.noreply.github.com>
navarone-feekery
navarone-feekery approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps! 🚀

@meghanmurphy1 meghanmurphy1 merged commit 4cf851a into main Feb 26, 2025
2 checks passed
@meghanmurphy1 meghanmurphy1 deleted the M4-enviroment-variable branch February 26, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarone-feekery navarone-feekery navarone-feekery approved these changes

Assignees

@meghanmurphy1 meghanmurphy1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghanmurphy1 @navarone-feekery