Add faux gem license headers #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
changed the title
artem-shelkovnikov
approved these changes
May 24, 2024
|
@artem-shelkovnikov there's already an MIT license file here: https://github.com/elastic/crawler/blob/main/vendor/faux/LICENSE And the gemspec had MIT in its license field: https://github.com/elastic/crawler/blob/main/vendor/faux/faux.gemspec Is this what you mean, or do you mean something else? |
|
Ah sorry my bad, I thought that these files are added in this PR, but they were added a while ago along with the LICENSE file. Haven't woken up yet 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided on Slack that for the vendored Faux gem we should keep the original MIT license.
This PR adds that license as a header to all Faux gem files.