Improve setup docs and add CLI docs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
navarone-feekery
commented
Jun 7, 2024
navarone-feekery
commented
- Add version compatibility
- Add tech-preview status
- Clean up Setup section
- Add CLI.md
- Move crawl instructions to CLI.md
|
@danajuratoni I will add a feature comparison table in a different PR |
leemthompo
reviewed
Jun 7, 2024
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
leemthompo
reviewed
Jun 7, 2024
|
@leemthompo thanks for all the feedback, it's really valuable. I think everything is addressed now. |
leemthompo
previously approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM. Thanks for iterating, thi now feels a great resource for getting started and understanding how the crawler works. 🎉
We'll work on more e2e examples when we start planning the full docs experience.
I'll defer to the team for any additional context or technical input that won't be on my radar for the repo docs right now.
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
leemthompo
approved these changes
Jun 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
- Add version compatibility - Add tech-preview status - Clean up Setup section - Add CLI.md - Move crawl instructions to CLI.md --------- Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
navarone-feekery
added a commit
that referenced
this pull request
Jun 17, 2024
Backports the following commits to 0.1: - Improve setup docs and add CLI docs (#44) Co-authored-by: Navarone Feekery <13634519+navarone-feekery@users.noreply.github.com> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.