-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary content extraction #74
Merged
navarone-feekery
merged 8 commits into
main
from
navarone/add-binary-content-extraction
Aug 21, 2024
Merged
Add binary content extraction #74
navarone-feekery
merged 8 commits into
main
from
navarone/add-binary-content-extraction
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
seanstory
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great. Good tests as always. :)
seanstory
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary content extraction support.
When a binary content file (such as a PDF) is encountered, Crawler will download the file and create an ES doc for ingestion.
The binary content of the file is added as a base64-encoded string to the
_attachment
field. The actual decoding is done through ES pipelines, which takes the decoded value and adds it to thebody
field on the doc. The_attachment
field is then removed.This can be enabled or disabled through the following configuration fields
This feature additionally closes #71
Checklists
Pre-Review Checklist
crawler.yml.example
andelasticsearch.yml.example
)v0.1.0
)make notice
if any dependencies have been addedRelease Note
Crawler can now extract binary content from files it encounters during a crawl.