Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Bug] Handle formatting empty list" #4087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "[Bug] Handle formatting empty list" #4087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion detection_rules/rule_formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def dump_list(self, v):
dump.append(' ' * 4 + self.dump_value(item))
return '[\n{},\n]'.format(',\n'.join(dump))

if v and all(isinstance(i, dict) for i in v):
if all(isinstance(i, dict) for i in v):
Copy link
Contributor

@traut traut Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make it clearer! Reading the code, it's not obvious that this check will return True for an empty list / iterator, but it will:

In [1]: all([])
Out[1]: True

In [2]: all(x for x in [])
Out[2]: True

If that's desirable, we can make it explicit by doing

if len(v) == 0 or all(isinstance(i, dict) for i in v):

# Compact inline format for lists of dictionaries with proper indentation
retval = "\n" + ' ' * 2 + "[\n"
retval += ",\n".join([' ' * 4 + self.dump_inline_table(u).strip() for u in v])
Expand Down
Loading