Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new detection rule set documentation to be included in the new docs. #4508

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 4, 2025

Requires:

This PR introduces the Elastic Docs V3 to the elastic/detection-rules repository.

https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main

This will pick up all TOML definition files and render them as documentation automatically.

cc @elastic/docs-engineering

@Mpdreamz Mpdreamz changed the title Feature/docs builder Create new detection rule set documentation to be included in the new docs. Mar 4, 2025
@Mikaayenson Mikaayenson added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the enhancement does not break existing functionality.
  • Review the enhancement with a peer or team member for additional insights.
  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.
  • Confirm that the proper version label is applied to the PR patch, minor, major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants