Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy and manage -> Monitoring post migration initial cleaning #314

Merged
merged 14 commits into from
Feb 5, 2025

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Feb 4, 2025

  • Front matter applies added to all docs
  • Some files renamed to avoid confusion.
  • 3 heroku documents migrated by mistake have been removed (mapped urls added to the right files).
  • double overview solved by deleting one file

Still a lot of work to do but I'd like to start with this.

@eedugon eedugon requested a review from shainaraskas February 4, 2025 19:38
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably dug in too deep here.

had a couple of questions about things that I wasn't sure applied to all deployment types, but as long as we validate them when we get to the refinement stage we should be ok

Couple of things to possibly address in this PR:

approved to unblock, but if you make changes you'll need another quick ✅ so lmk if you need it from me

as a side note, this PR inspired me to open this feature request: elastic/docs-builder#420 :)

shainaraskas
shainaraskas previously approved these changes Feb 4, 2025
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably dug in too deep here.

had a couple of questions about things that I wasn't sure applied to all deployment types, but as long as we validate them when we get to the refinement stage we should be ok

Couple of things to possibly address in this PR:

approved to unblock, but if you make changes you'll need another quick ✅ so lmk if you need it from me

as a side note, this PR inspired me to open this feature request: elastic/docs-builder#420 :)

@eedugon eedugon requested a review from kosabogi February 5, 2025 10:27
@eedugon eedugon merged commit b6fb95e into elastic:main Feb 5, 2025
4 checks passed
@eedugon eedugon deleted the deploy_and_manage-monitoring branch February 5, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants