Hook exit only after descriptors are closed. Fixes #216 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were sending exit events before the file descriptors were closed. The tests are likely naive enough to always properly close the socket and then terminate. This is easy to see by connecting and killing it. The solution is to move the hook down to proc_exit_connector(). In order to respect the group_dead dance we have to now keep state of who got it, we use an empty state, meaning the existence of the entry in the map is the state.
|
I think I found a better hook: EDIT: no i did not, it gets inlined. |
|
The CI is failing because I think the kernel doesn't have CONFIG_PROC_EVENTS |
|
So we changed to sched_process_exit and CI is happy, I pushed a second commit updating the comments. |
nicholasberlin
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were sending exit events before the file descriptors were closed. The tests are likely naive enough to always properly close the socket and then terminate. This is easy to see by connecting and killing it.
The solution is to move the hook down to
proc_exit_connector()sched_process_exit(). In order to respect the group_dead dance we have to now keep state of who got it, we use an empty state, meaning the existence of the entry in the map is the state.