Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended LogEventConverter.ConvertToEcs<>() #460

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

bsnsaxo
Copy link
Contributor

@bsnsaxo bsnsaxo commented Nov 11, 2024

Extended LogEventConverter.ConvertToEcs<>() with an optional EcsDocumentCreationCache input parameter that gets passed into EcsDocument.CreateNewWithDefaults<>()

This is to support overwrites of static data such as those in EcsDocument.Service

…entCreationCache input parameter that gets passed into EcsDocument.CreateNewWithDefaults<>()

This is to support overwrites of static data such as those in EcsDocument.Service
Copy link

cla-checker-service bot commented Nov 11, 2024

💚 CLA has been signed

@bsnsaxo bsnsaxo closed this Nov 12, 2024
@bsnsaxo bsnsaxo reopened this Nov 12, 2024
@Mpdreamz Mpdreamz closed this Jan 29, 2025
@Mpdreamz Mpdreamz reopened this Jan 29, 2025
@Mpdreamz
Copy link
Member

run docs-build

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @bsnsaxo !

@Mpdreamz Mpdreamz merged commit 2df5d15 into elastic:main Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants