-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Stage 2: Adding Apple Platform specific fields #2370
Merged
mjwolf
merged 15 commits into
elastic:main
from
txhaflaire:adding_apple_platform_fields_stage2
Sep 11, 2024
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c8138cf
Updating the RFC and moving it to stage two.
txhaflaire 8429be6
updated PR reference number in RFC document.
txhaflaire 9153714
Merge branch 'main' into adding_apple_platform_fields_stage2
txhaflaire 532b42e
Added fields to related yml files and run make
txhaflaire 67cc97c
Merge branch 'main' into adding_apple_platform_fields_stage2
mjwolf 19335ff
Updated process.yml to remove example values and enhanced the short_o…
txhaflaire 18ecccf
Merge branch 'adding_apple_platform_fields_stage2' of https://github.…
txhaflaire b243fd1
added description and reverted the short_override back to it's initia…
txhaflaire d574799
added indents and moved descrption to a new line
txhaflaire d6fec81
shortened it to 119 chars
txhaflaire cdbbc94
Moved it back into short_override.
txhaflaire d609b6f
just try&error, ran make again locally.
txhaflaire eb96731
Merge branch 'main' into adding_apple_platform_fields_stage2
txhaflaire 5fe91eb
Merge branch 'main' into adding_apple_platform_fields_stage2
mjwolf 57a3427
Update rfc date
mjwolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
string
is a valid field type. Should this bekeyword
?