-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all usages of fleettools to use the installed Agent ID #7054
base: main
Are you sure you want to change the base?
Update all usages of fleettools to use the installed Agent ID #7054
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There were cloud instability while creating deployment, restarting tests. |
buildkite test this |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until we discuss with the team about what DRY is and when to try to perform it and what developers of integration tests should seek out and all of us collectively agree to a definition, I believe that this PR should not be merged
Happy to discuss. |
I am working on cleaning this up more from @cmacknz comments to have the install functions return the agent ID, that way its clear what the Agent ID is from the installation with enrollment step. Placing back in draft while I do this. |
|
What does this PR do?
Updates all integration tests to use the installed Elastic Agent ID from the status output to check with Fleet for information about the specific Elastic Agent.
Why is it important?
This ensures that the tests in the integration framework are only communicating with Fleet about that specific Elastic Agent. This removes the need to filter based on hostname or doing any type of paging with the Kibana API to find that specific Elastic Agent. We know the Elastic Agent ID as the test installed it, it should always use that ID.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works(all integration tests)[ ] I have added an entry in(testing only)./changelog/fragments
using the changelog toolDisruptive User Impact
None
How to test this PR locally
mage integration:test
Related issues
Questions to ask yourself