-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fips): bump sarama to drop kerberos lib in fips mode #7225
base: main
Are you sure you want to change the base?
Conversation
bump sarama to latest commit and verify kerberos lib is not linked in the binary
|
💚 Build Succeeded
cc @kruskall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says:
bump sarama to latest commit and verify kerberos lib is not linked in the binary
Have you manually validated that the kerberos lib is not linked?
I did before otel was added 😭 Thanks for mentioning this! It seems kerberos is still included because of otel using another version of sarama |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
What does this PR do?
bump sarama to latest commit and verify kerberos lib is not linked in the binary
Why is it important?
avoid linking the kerberos lib in the final binary in fips mode
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself