feat: add helm package mage target #7232
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
* upstream/main: feat: bump go to 1.24.0 (elastic#6932) [CI] Fix Core DRA crossbuild (elastic#7203) fix(ci): Use correct `READ_ONLY` access value instead of `READ` (elastic#7239) ci(buildkite): add initial elastic-agent-helm-charts pipeline (elastic#7176) chore: update elastic-agent-libs to v0.18.8 (elastic#6938) [flakiness] Correct group for TestEndpointAgentServiceMonitoring (elastic#7165)
v1v
reviewed
Mar 6, 2025
Comment on lines
19
to
21
| plugins: | ||
| - elastic/oblt-google-auth#v1.0.0: | ||
| lifetime: 1800 # seconds |
There was a problem hiding this comment.
I use https://github.com/elastic/oblt-google-auth-buildkite-plugin
Still need to create the relevant copy file from local to the specific bucket
v1v
reviewed
Mar 6, 2025
|
|
||
| set -euo pipefail | ||
|
|
||
| echo "--- mage package tests" |
then we can infer the helmchart file name
speed the build
v1v
reviewed
Mar 7, 2025
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
v1v
reviewed
Mar 7, 2025
|
|
||
| agentVersion := bversion.GetParsedAgentPackageVersion() | ||
| agentCoreVersion := agentVersion.CoreVersion() | ||
| agentImageTag := agentCoreVersion + "-SNAPSHOT" |
There was a problem hiding this comment.
for some reason SNAPSHOT=true is not honoured
CHARTS_URL: "https://storage.googleapis.com/elastic-agent-helm-chart/elastic-agent-9.1.0-beta.tgz"
when using SNAPSHOT=true mage helm:package
is that the expected behaviour?
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new Mage target,
helm:package, to package the Elastic-Agent Helm chart.This is a necessary step toward automating the Helm chart release process.
Why is it important?
This change is critical for supporting the release of Elastic-Agent Helm charts in a structured and automated manner:
DRA) and production (release) packages (controlled by explicitly setting SNAPSHOT="false" for production).Checklist
./changelog/fragmentsusing the changelog tool.Disruptive User Impact
This change does not introduce disruptive user impact but improves automation for Helm chart releases.
How to test this PR locally
CI
Run https://buildkite.com/elastic/elastic-agent-helm-charts
Related issues
N/A