Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Validate catalog-info.yaml #7240

Merged
merged 2 commits into from
Mar 7, 2025
Merged

chore(ci): Validate catalog-info.yaml #7240

merged 2 commits into from
Mar 7, 2025

Conversation

nuugen
Copy link
Member

@nuugen nuugen commented Mar 6, 2025

What does this PR do?

Validate that definitions in catalog-info.yaml are correct.

Why is it important?

To ensure well-formed data ingested into EngProd's tooling.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@nuugen nuugen marked this pull request as ready for review March 6, 2025 12:19
@nuugen nuugen requested a review from a team as a code owner March 6, 2025 12:19
@mergify mergify bot assigned nuugen Mar 6, 2025
@nuugen
Copy link
Member Author

nuugen commented Mar 6, 2025

Build failure is completely expected due to currently malformed catalog-info.yaml. It should be fixed after #7239.

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @nuugen

@nuugen nuugen merged commit 02b2c87 into main Mar 7, 2025
13 checks passed
@nuugen nuugen deleted the validate-catalog branch March 7, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants