-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system tests] Validate fields are documented via the mappings generated after ingesting docs comparing them to the preview mappings #2206
Comments
Some assumptions made when adding this new validation based on mappings:
|
While working on #2214 , there have been some issues found while testing with the packages in the integration repository that are not related to the dynamic templates. Support to validate mappings with the dynamic templates is going to be tackle in #2207 Issues found are detailed in #2214 (comment) In summary, those issues are:
|
With the latest changes introduced in the PR, the missing failures are related to different mappings found in ECS. That could probably be checked as part of the following issue where dynamic templates are going to be considered #2207 WDYT @jsoriano ? Nested and groups field/mappings should be fixed , testing it in elastic/integrations#11828 (build https://buildkite.com/elastic/integrations/builds/19362). Found an unexpected error for |
Yes, I think we can go on with current implementation and polish it in follow ups.
This looks like an issue in Fleet (see #2214 (comment)), I will take a deeper look tomorrow. |
In order to try to be agnostic to the structure of the documents ingested to run the validation in system tests. It would be helpful to run validations comparing the mapping definitions instead.
These validations should be done with these two sets of mappings:
Being available these two sets of mappings, it would be needed to validate whether or not each mapping present in the data stream (after ingesting docs) has a corresponding mapping in the preview.
It should be taken into account that:
agent.*
,host.*
, ...) as it is done nowadays (link)For now, the errors that could be raised as part of this validation should not make fail the validation process, therefore:
To be tested:
The text was updated successfully, but these errors were encountered: