Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mappings link does not exist for the internal-knowledge-search example #181

Closed
liu-xiao-guo opened this issue Feb 1, 2024 · 1 comment · Fixed by #184
Closed

mappings link does not exist for the internal-knowledge-search example #181

liu-xiao-guo opened this issue Feb 1, 2024 · 1 comment · Fixed by #184
Assignees
@seanstory

Comments

@liu-xiao-guo
Copy link

As described in the readme file, the following link does not exist at all: https://github.com/elastic/elasticsearch-labs/blob/main/example-apps/internal-knowledge-search/src/config/documentsToSearchResultMappings.json

image

In addition, I read the blog at https://www.elastic.co/search-labs/blog/articles/dls-internal-knowledge-search. I I am not wrong, the DIS should be DLS, right?

image
@seanstory seanstory mentioned this issue Feb 1, 2024
Merged
@seanstory
Copy link
Member

the following link does not exist at all

Thanks for flagging! Fixed in #184

I am not wrong, the DIS should be DLS, right?

Woops! Yep. Looks like my finger came off of "shift" in the middle of typing that. :) Will get that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanstory seanstory

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken link after code reorganization elastic/elasticsearch-labs
2 participants
@seanstory @liu-xiao-guo