-
Notifications
You must be signed in to change notification settings - Fork 101
[OpenAPI] Add a CLI to configure export parameters #4426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4426-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbbdd21645c85d00312f8f2fddc663a39209ee79
# Push it to GitHub
git push --set-upstream origin backport-4426-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4426-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbbdd21645c85d00312f8f2fddc663a39209ee79
# Push it to GitHub
git push --set-upstream origin backport-4426-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4426-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dbbdd21645c85d00312f8f2fddc663a39209ee79
# Push it to GitHub
git push --set-upstream origin backport-4426-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19 Then, create a pull request where the |
(cherry picked from commit dbbdd21)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit dbbdd21)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit dbbdd21)
(cherry picked from commit dbbdd21)
The work on the API reference docs requires a specialized version of the OpenAPI export (e.g. merging operations in PR #4415). This PR adds CLI arguments to the OpenAPI export so that we can easily produce several versions.
The native (
main.rs
) and the wasm (compiler-wasm-lib/lib.rs
) main entry points now use the same CLI parameters. Theclap
library isn't compatible with wasm and has been replaced byargh
, which is also smaller.PR #4415 is dependent on this one to add the "merge operations" CLI flag.