Skip to content

Add since and method_request to data stream settings #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add since and method_request to data stream settings #4492

wants to merge 2 commits into from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 6, 2025

This PR is follow-up to #4416 to add the since availability details and the method_request values related to #4445

@lcawl lcawl requested a review from masseyke June 6, 2025 23:14
@lcawl lcawl added the skip-backport This pull request should not be backported label Jun 6, 2025
@lcawl lcawl mentioned this pull request Jun 6, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
indices.get_data_stream_settings ⚪ Missing test Missing test
indices.put_data_stream_settings ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review June 6, 2025 23:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
indices.get_data_stream_settings ⚪ Missing test Missing test
indices.put_data_stream_settings ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masseyke masseyke Awaiting requested review from masseyke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-backport This pull request should not be backported specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lcawl