Skip to content

ESQL: Create fewer documents in lookup tests #126874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 15, 2025

This lowers the number of documents used to test lookup because we have a few failures over the last few months. These are all cases that we expect to pass so fewer documents should make them even more likely to pass.

Closes #125913
Closes #125779

This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes elastic#125913
Closes elastic#125779
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 v8.19.0 v9.1.0 labels Apr 15, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine merged commit 2e43757 into elastic:main Apr 15, 2025
17 checks passed
@nik9000 nik9000 deleted the esql_heap_attack_lookup_less branch April 15, 2025 19:57
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Apr 15, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes elastic#125913 Closes elastic#125779
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18
8.x

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Apr 15, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes elastic#125913 Closes elastic#125779
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Apr 15, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes elastic#125913 Closes elastic#125779
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 16, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes elastic#125913 Closes elastic#125779
elasticsearchmachine pushed a commit that referenced this pull request Apr 16, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes #125913 Closes #125779
elasticsearchmachine pushed a commit that referenced this pull request Apr 16, 2025
This lowers the number of documents used to test lookup because we have
a few failures over the last few months. These are all cases that we
expect to *pass* so fewer documents should make them even more likely to
pass.

Closes #125913 Closes #125779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] HeapAttackIT testLookupExplosionNoFetch failing [CI] HeapAttackIT testLookupExplosion failing
2 participants