Skip to content

Start polling after data computation is started #128575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

idegtiarenko
Copy link
Contributor

This change starts polling results after data node is messaged to execute query plan.
Prior this change sometimes coordinator node was fast enough to execute first poll before the data node even received the plan.
This change would delay first poll and reduce amount of transport requests we do, especially for small queries.

@idegtiarenko idegtiarenko requested a review from dnhatn May 28, 2025 13:25
@idegtiarenko idegtiarenko added >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.1.0 labels May 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @idegtiarenko. Can you backport this PR to 8.19 too?

@idegtiarenko idegtiarenko added auto-backport Automatically create backport pull requests when merged v8.19.0 labels May 28, 2025
@idegtiarenko idegtiarenko merged commit 03173af into elastic:main Jun 2, 2025
18 checks passed
@idegtiarenko idegtiarenko deleted the reorder_commands branch June 2, 2025 07:34
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Jun 2, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 3, 2025
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants