ESQL - Refactor full text functions optimizer tests #128611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
Team:Analytics
|
@elasticmachine run elasticsearch-ci/part-2 |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
removed
the
Team:Search Relevance
carlosdelest
requested review from
tteofili,
ioanatia,
ChrisHegarty,
svilen-mihaylov-elastic,
fang-xing-esql and
afoucret
svilen-mihaylov-elastic
approved these changes
May 29, 2025
tteofili
approved these changes
May 30, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Jun 2, 2025
…unctions (elastic#128611) (cherry picked from commit b688080) # Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizerTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage to
LocalPhysicalPlanOptimizerTestsfor full text functions.This PR creates a new inner class that encapsulates test case information for full text functions, namely the ESQL query and the corresponding QueryBuilder that it will create.
Each full text function extends the test case class to provide how an ESQL query looks like and what QueryBuilder it creates, so it can be used in tests to provide the query and check the results respectively.
Existing methods have been refactored to use this test case as a parameter, so every full text function is covered by existing test cases.
As a follow up step, we should refactor full text functions tests into its own class that uses parameterized tests - but as that would imply extracting some common methods, I have preferred to do this as a first step for adding
multi_matchandknnfunctions test coverage.