Skip to content

Mark Token Pruning for Sparse Vector as GA #128854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mark Token Pruning for Sparse Vector as GA #128854

wants to merge 5 commits into from

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Jun 3, 2025

A docs change to remove the [preview] labels for the token pruning configuration items for the Sparse Vector query as we get ready to put these into GA.

@markjhoy markjhoy requested review from kderusso and a team June 3, 2025 17:40
@markjhoy markjhoy added >docs General docs changes release highlight :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.0 v9.1.0 Team:Search - Relevance The Search organization Search Relevance team labels Jun 3, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Jun 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Hi @markjhoy, I've created a changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kderusso
kderusso approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to clean up a couple issues of release notes and fix the build.

Could you please also open a PR to mark this as stable in the spec? See: https://github.com/elastic/elasticsearch/pull/125302/files

Thanks!

@markjhoy
Copy link
Contributor Author

markjhoy commented Jun 3, 2025

Could you please also open a PR to mark this as stable in the spec? See: https://github.com/elastic/elasticsearch/pull/125302/files

@kderusso - what spec are you referring to?

@markjhoy
Copy link
Contributor Author

markjhoy commented Jun 4, 2025

NOTE: do not merge this yet - wait at least until #126739 is merged, and we consult appropriate stakeholders

leemthompo
leemthompo reviewed Jun 11, 2025
View reviewed changes
docs/reference/query-languages/query-dsl/query-dsl-sparse-vector-query.md
@@ -63,21 +63,21 @@ GET _search
: (Optional, dictionary) A dictionary of token-weight pairs representing the precomputed query vector to search. Searching using this query vector will bypass additional inference. Only one of `inference_id` and `query_vector` is allowed.

`prune`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`prune`
`prune` {applies_to}`stack: preview 9.0, ga 9.1`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies for all, placing this applies_to tag after each

leemthompo
leemthompo requested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to update the applies_to versioning metadata before we can merge, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo requested changes

@ioanatia ioanatia ioanatia approved these changes

@kderusso kderusso kderusso approved these changes

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
>docs General docs changes release highlight :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Docs Meta label for docs team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markjhoy @elasticsearchmachine @ioanatia @leemthompo @kderusso @Samiul-TheSoccerFan