Expand bcUpgradeTask to run more test suites. #128983
Conversation
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| return Boolean.parseBoolean( | ||
| getSetting( | ||
| "xpack.security.enabled", | ||
| getVersion().equals(Version.fromString("0.0.0")) || getVersion().onOrAfter("8.0.0") ? "true" : "false" |
There was a problem hiding this comment.
This fix makes sure to enable security if using the magic version number 0.0.0 (we're always > 8.0.0 in this case as we won't be backporting this as far).
Without this fix any test requiring security would fail.
mosche
added
auto-backport
| @@ -24,3 +25,10 @@ buildParams.bwcVersions.withWireCompatible { bwcVersion, baseName -> | |||
| systemProperty("tests.old_cluster_version", bwcVersion) | |||
| } | |||
| } | |||
|
|
|||
| tasks.register("bcUpgradeTest", StandaloneRestIntegTestTask) { | |||
There was a problem hiding this comment.
lets extract that task registration into a plugin script and avoid all this duplication of task registration logic. we do something simliar to bwc tests.
see https://github.com/elastic/elasticsearch/blob/ae569def9c2cf95df3a642d431d8b8e63f6c9c19/build-tools-internal/src/main/groovy/elasticsearch.bwc-test.gradle as an example. you would just wrap this task registration lgoic into build-tools-internal/src/main/groovy/elasticsearch.bc-update-test.gradle and then apply the script as a plugin by
apply plugin: 'elasticsearch.bc-upgrade-test'
Relates to ES-11904
#128984 contains the changes to the PR buildkite pipeline to test this change while the buildkite changes are not merged yet.