Skip to content

Fix NPE in semantic highlighter #128989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Jun 5, 2025

This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes #128975

This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes elastic#128975
@jimczi jimczi added >bug auto-backport Automatically create backport pull requests when merged :Search Relevance/Search Catch all for Search Relevance v8.19.0 v9.1.0 v9.0.3 labels Jun 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jun 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @jimczi, I've created a changelog YAML for you.

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@jimczi jimczi merged commit a9ea5c8 into elastic:main Jun 6, 2025
18 checks passed
@jimczi jimczi deleted the semantic_highlight_npe branch June 6, 2025 12:06
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19
9.0

jimczi added a commit to jimczi/elasticsearch that referenced this pull request Jun 6, 2025
This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes elastic#128975
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Jun 6, 2025
This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes elastic#128975
elasticsearchmachine pushed a commit that referenced this pull request Jun 6, 2025
This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes #128975
elasticsearchmachine pushed a commit that referenced this pull request Jun 6, 2025
This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes #128975
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 9, 2025
This PR fixes an NPE in the semantic highlighter when the document being highlighted doesn't contain value for the semantic text field.

Closes elastic#128975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.19.0 v9.0.3 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic text highlighter throws NPE in certain scenarios
5 participants