Skip to content

Include Pinned Retriever in 8.19 Documentation #129217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 8.19
Choose a base branch
from

Conversation

mridula-s109
Copy link
Contributor

Summary of changes

  • Added details about the Pinned Retriever to retrievers-overview .
  • Ensured that only the intended documentation file was modified, with no unrelated changes.

@mridula-s109 mridula-s109 requested review from ioanatia, kderusso, a team and Copilot June 10, 2025 17:58
@mridula-s109 mridula-s109 self-assigned this Jun 10, 2025
@mridula-s109 mridula-s109 added >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch documentation v8.19.0 Team:Search - Relevance The Search organization Search Relevance team labels Jun 10, 2025
Copy link
Contributor

Documentation preview:

Copilot

This comment was marked as outdated.

@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) and removed Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Jun 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@mridula-s109 mridula-s109 force-pushed the update-pinned-docs-8.19 branch from 40a8242 to 07d8f88 Compare June 11, 2025 15:15
@mridula-s109 mridula-s109 requested a review from Copilot June 11, 2025 15:15
Copilot

This comment was marked as outdated.

@mridula-s109 mridula-s109 requested a review from Copilot June 17, 2025 13:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the search documentation to include details for the new Pinned Retriever in version 8.19.

  • Added an entry for Pinned Retriever in the retrievers overview file.
  • Included a new example section with parameter details and usage examples for the pinned retriever in the examples file.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/reference/search/search-your-data/retrievers-overview.asciidoc Added a new bullet referencing the Pinned Retriever with a brief explanation.
docs/reference/search/search-your-data/retrievers-examples.asciidoc Introduced a new example section for the Pinned Retriever with detailed parameter and usage instructions.

@mridula-s109
Copy link
Contributor Author

@kderusso Have made changes related to the index usage as discussed in the call yesterday.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please follow the standard that we use for other docs. Please reach out to @leemthompo if you have questions on where you should put stuff as well, thanks.


The pinned retriever allows you to always place specific documents at the top of the results, with the remaining hits provided by a secondary retriever.

.Parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think parameters belong here, it should be in the retrievers overview. If you notice no parameters are in any of the other examples. Instead, please add parameter information to retriever.asciidoc and follow the paradigm that we use for other retreivers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ The examples pages should only house examples, not reference info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants