-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Include Pinned Retriever in 8.19 Documentation #129217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.19
Are you sure you want to change the base?
Conversation
Documentation preview: |
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/search-relevance (Team:Search - Relevance) |
40a8242
to
07d8f88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the search documentation to include details for the new Pinned Retriever in version 8.19.
- Added an entry for Pinned Retriever in the retrievers overview file.
- Included a new example section with parameter details and usage examples for the pinned retriever in the examples file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
docs/reference/search/search-your-data/retrievers-overview.asciidoc | Added a new bullet referencing the Pinned Retriever with a brief explanation. |
docs/reference/search/search-your-data/retrievers-examples.asciidoc | Introduced a new example section for the Pinned Retriever with detailed parameter and usage instructions. |
@kderusso Have made changes related to the index usage as discussed in the call yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please follow the standard that we use for other docs. Please reach out to @leemthompo if you have questions on where you should put stuff as well, thanks.
|
||
The pinned retriever allows you to always place specific documents at the top of the results, with the remaining hits provided by a secondary retriever. | ||
|
||
.Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think parameters belong here, it should be in the retrievers overview. If you notice no parameters are in any of the other examples. Instead, please add parameter information to retriever.asciidoc and follow the paradigm that we use for other retreivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ The examples pages should only house examples, not reference info :)
Summary of changes
retrievers-overview
.