Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more resilitent defaults to ES client #4515

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Feb 26, 2025

Adding more resilient defaults to ES client
Comparing default with updated version

x Default Updated comment
Retry on Status 502, 503, 504 429, 502, 503, 504 adding retries on backpressure TooManyRequests
Retry on error fail always Connection Refused and Reset retry when waiting for ES to spin up or ES is restarting
Retry Backoff none exponential from 500ms up to 10s max retries were immediate before
Max retries 3 5 to stay aligned with other products talking to ES like APM or Profiling

Fixes #3082

Copy link
Contributor

mergify bot commented Feb 26, 2025

This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@michalpristas michalpristas changed the title Running CI Adding more resilitent defaults to ES clietn Feb 27, 2025
@michalpristas michalpristas marked this pull request as ready for review February 27, 2025 13:09
@michalpristas michalpristas requested a review from a team as a code owner February 27, 2025 13:09
@michalpristas michalpristas self-assigned this Feb 27, 2025
@michalpristas michalpristas added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 27, 2025
@michalpristas michalpristas changed the title Adding more resilitent defaults to ES clietn Adding more resilitent defaults to ES client Feb 27, 2025
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalpristas Thanks for updating the code. Looks good. I will wait for green CI before approval.

@michalpristas
Copy link
Contributor Author

failing on unrelated lint and failing cloud e2e that fails to be created across PRs

swiatekm
swiatekm previously approved these changes Mar 3, 2025
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like some more clarity on where we're getting the backoff values.

michalpristas and others added 3 commits March 3, 2025 09:49
michel-laterman
michel-laterman previously approved these changes Mar 4, 2025
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgth, could you fix the linter before merging?

@jlind23 jlind23 requested a review from blakerouse March 5, 2025 07:42
@jlind23
Copy link
Contributor

jlind23 commented Mar 5, 2025

Requesting Blake's review as CI is now green.

@michalpristas michalpristas dismissed stale reviews from michel-laterman and swiatekm via 40cbdce March 5, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Retry on ES connection error
5 participants