-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more resilitent defaults to ES client #4515
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalpristas Thanks for updating the code. Looks good. I will wait for green CI before approval.
failing on unrelated lint and failing cloud e2e that fails to be created across PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like some more clarity on where we're getting the backoff values.
Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
…er into feat/es-retries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgth, could you fix the linter before merging?
Requesting Blake's review as CI is now green. |
|
40cbdce
Adding more resilient defaults to ES client
Comparing default with updated version
Fixes #3082