Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline.package.mbp.yml #4555

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Update pipeline.package.mbp.yml #4555

merged 2 commits into from
Mar 6, 2025
+1 −2

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Mar 6, 2025

GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

What is the problem this PR solves?

// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@jlind23
Update pipeline.package.mbp.yml
f9fb274 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1
@jlind23 jlind23 requested a review from a team as a code owner March 6, 2025 09:04
@jlind23 jlind23 self-assigned this Mar 6, 2025
@jlind23 jlind23 enabled auto-merge (squash) March 6, 2025 09:04
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

This pull request does not have a backport label. Could you fix it @jlind23? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@jlind23 jlind23 added the backport-active-all Automated backport with mergify to all the active branches label Mar 6, 2025
@jlind23
Copy link
Contributor Author

jlind23 commented Mar 6, 2025

buildkite test it

@v1v
refactor: centralise the gvm in the function itself
e7ddc20 
I don't see any need to have two variables but centralising the version in the installed function
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 merged commit 20c2254 into main Mar 6, 2025
9 checks passed
@jlind23 jlind23 deleted the jlind23-patch-1 branch March 6, 2025 11:31
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
4467df8 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
8310eb8 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
7573a85 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
This was referenced Mar 6, 2025
Open
Open
Open
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
6cdbecc 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
f7caf7a 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
@jlind23 @mergify
Update pipeline.package.mbp.yml (#4555)
82631b1 
GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml
#	.buildkite/scripts/common.sh
This was referenced Mar 6, 2025
Merged
Open
Closed
jlind23 added a commit that referenced this pull request Mar 6, 2025
@mergify @jlind23
[8.16](backport #4555) Update pipeline.package.mbp.yml (#4559)
a79f5de 
* Update pipeline.package.mbp.yml (#4555)

GVM is unable to install Go 1.24.0 on main due to a missing fix that landed in 0.5.1

(cherry picked from commit 20c2254)

# Conflicts:
#	.buildkite/pipeline.yml

* Update pipeline.yml

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

@swiatekm swiatekm swiatekm approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@jlind23 jlind23

Labels
backport-active-all Automated backport with mergify to all the active branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlind23 @v1v @swiatekm