Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Connectors] Add index name as input var #11267

Merged
merged 4 commits into from
Oct 7, 2024
Merged

[Elastic Connectors] Add index name as input var #11267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7723f5
[Elastic Connectors] Add index name as input var
jedrazb Sep 27, 2024
88104c3
Pass connector name instead of index name
jedrazb Oct 1, 2024
cd4122f
reduce code duplication, update changelog
jedrazb Oct 3, 2024
c635362
Update changelog, change connector_name to optional var
jedrazb Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/elastic_connectors/agent/input/github.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
service_type: github
{{#if connector_name}}
connector_name: {{connector_name}}
{{/if}}
3 changes: 3 additions & 0 deletions packages/elastic_connectors/agent/input/google_drive.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
service_type: google_drive
{{#if connector_name}}
connector_name: {{connector_name}}
{{/if}}
5 changes: 5 additions & 0 deletions packages/elastic_connectors/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: 0.0.2
changes:
- description: Add connector_name as the connector input variable
type: enhancement
link: https://github.com/elastic/integrations/pull/11267
- version: 0.0.1
changes:
- description: Initial draft of the package
Expand Down
15 changes: 13 additions & 2 deletions packages/elastic_connectors/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 3.2.1
name: elastic_connectors
title: "Elastic Connectors"
version: 0.0.1
version: 0.0.2
source:
license: "Elastic-2.0"
description: "Sync data from source to the Elasticsearch index."
Expand All @@ -28,7 +28,7 @@ policy_templates:
title: GitHub & GitHub Enterprise Server Connector
icons:
- src: /img/service_type/github.svg
title: Google Drive logo
title: GitHub logo
size: 32x32
type: image/svg+xml
description: Use a connector to sync data from your GitHub data source.
Expand All @@ -42,6 +42,14 @@ policy_templates:
- type: connectors-py
title: GitHub & GitHub Enterprise Server Connector
description: Connectors syncs data from an original data source to an Elasticsearch index.
vars:
- &connector_name
name: connector_name
type: text
title: Connector Name
required: false
show_user: false # TODO: Change to true once this is fixed https://github.com/elastic/kibana/issues/194310
description: Connector name to identify the connector in the UI
template_path: github.yml.hbs
- name: google_drive
title: Google Drive Connector
Expand All @@ -61,7 +69,10 @@ policy_templates:
- type: connectors-py
title: Google Drive Connector
description: Connectors syncs data from an original data source to an Elasticsearch index.
vars:
- <<: *connector_name
template_path: google_drive.yml.hbs

owner:
github: elastic/search-extract-and-transform
type: elastic