Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft_sentinel: Add agentless deployment #12586

Merged
merged 8 commits into from
Mar 5, 2025

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Feb 4, 2025

Proposed commit message

As part of onboarding integrations into agentless deployments, 
this PR adds agentless deployment to Microsoft Sentinel integration.

Ref:
- https://docs.elastic.dev/security-solution/cloud-security/agentless/onboard-integration

cc: @jamiehynds

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Screenshot 2025-03-05 at 9 14 50 PM Screenshot 2025-02-05 at 6 49 43 PM Screenshot 2025-02-05 at 6 50 51 PM

Successful ingestion in Cloud environment (8.18.0):
Screenshot 2025-02-13 at 5 45 09 PM

Successful ingestion in Serverless environment:
Screenshot 2025-02-13 at 5 14 15 PM

@kcreddy kcreddy force-pushed the sentinel-agentless branch from 33a051c to 26e5fde Compare February 4, 2025 08:27
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔 Build #21543 failed 33a051c532f931067332dc21173dd53412f49c06

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy self-assigned this Feb 5, 2025
@kcreddy kcreddy added the enhancement New feature or request label Feb 5, 2025
@kcreddy kcreddy requested a review from a team February 5, 2025 13:22
@kcreddy kcreddy marked this pull request as ready for review February 5, 2025 13:22
@kcreddy kcreddy requested a review from a team as a code owner February 5, 2025 13:22
@kcreddy kcreddy added Integration:microsoft_sentinel Microsoft Sentinel Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Feb 5, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy force-pushed the sentinel-agentless branch from f059f98 to 393c46a Compare February 7, 2025 05:58
@kcreddy kcreddy removed request for a team February 7, 2025 05:59
@jamiehynds jamiehynds requested a review from a team February 7, 2025 09:27
@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 11, 2025

Thanks for reviewing @chemamartinez 😄
We would like to run some smoke-tests with valid Microsoft Sentinel credentials. So just waiting for them and other reviews before merging.

@qcorporation
Copy link
Collaborator

@kcreddy do you need to update the kibana constraint to ^8.18 || ^9.0 ?

@qcorporation
Copy link
Collaborator

qcorporation commented Feb 13, 2025

@kcreddy can you please see if it works with both inputs azure-eventhub ?

Good catch @qcorporation, I think agentless support is limited to CEL/httpjson at the moment, but Azure Event Hub is on the roadmap (@nimarezainia).

We'll need to ensure it's clear in docs/UI that agentless support for Sentinel is limited to API and not supported for Event Hub.

@kcreddy we should be testing on a 8.18 install. Within Kibana this input for agentless should not be available. If it is available then we need to file a ticket with Kibana as this should have been disabled by this ticket: elastic/kibana#202091

@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 13, 2025

@kcreddy we should be testing on a 8.18 install. Within Kibana this input for agentless should not be available. If it is available then we need to file a ticket with Kibana as this should have been disabled by this ticket: elastic/kibana#202091

@qcorporation, I created: elastic/kibana#211092 for removing Azure Eventhub input from Agentless.

cc: @jamiehynds

@kcreddy kcreddy marked this pull request as ready for review February 13, 2025 19:50
@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 13, 2025

@qcorporation @jamiehynds ,
I was able to successfully test with API (CEL input) in both Cloud (8.18.0) and Serverless environments.

Successful ingestion in Cloud environment (8.18.0) Screenshot 2025-02-13 at 5 45 09 PM
Successful ingestion in Serverless environment Screenshot 2025-02-13 at 5 14 15 PM

@nimarezainia
Copy link
Contributor

@kcreddy thanks for this work.
@qcorporation @kcreddy @smriti0321 what's the level of testing that will be performed on this integration? We have also been modeling the impact on COGs, at the moment portion of the cogs will depend on volume of traffic ingested.

Seems that for this integration the default container sizes are used, which means that there may not be COGS related concern. However do we know that the default (1cpu, 1GiB) container is sufficient for MSFT sentinel?

I think as we start onboarding more integrations to agentless some level of stress testing would be good just to see if the sizing of the infrastructure is suitable. let me know your thoughts.

@nimarezainia
Copy link
Contributor

@kcreddy once the eventhub inout is blocked, what would the behavior be here for this integration? the MSFT sentinel events are to be ingested via Eventhub. if at the top level the integration is nominated to be agentless, would the user be allowed to enable collection of events?

@kcreddy kcreddy marked this pull request as draft February 17, 2025 06:34
@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 17, 2025

Moved the PR to draft once again as we are waiting on elastic/kibana#211092.

@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 17, 2025

@kcreddy once the eventhub inout is blocked, what would the behavior be here for this integration? the MSFT sentinel events are to be ingested via Eventhub. if at the top level the integration is nominated to be agentless, would the user be allowed to enable collection of events?

@nimarezainia, the Microsoft Sentinel integration currently supports 2 inputs: API (CEL input) and EventHub. As we block EventHub input, the users can ingest alerts and incidents via API. The other data-stream Microsoft Sentinel Events, i.e., Collecting Events from Microsoft Sentinel via Azure Event Hub will not show up and remain hidden to the users.

@nimarezainia
Copy link
Contributor

@kcreddy once the eventhub inout is blocked, what would the behavior be here for this integration? the MSFT sentinel events are to be ingested via Eventhub. if at the top level the integration is nominated to be agentless, would the user be allowed to enable collection of events?

@nimarezainia, The Microsoft Sentinel integration currently supports 2 inputs: API (CEL input) and EventHub. As we block EventHub, the users can ingest alerts and incidents via API.

My question is around the integrations UI. Once the user has chosen Agentless - I assume the toggle for sentinel events will stay off and user unable to enable it. is this correct?

@kcreddy
Copy link
Contributor Author

kcreddy commented Feb 17, 2025

My question is around the integrations UI. Once the user has chosen Agentless - I assume the toggle for sentinel events will stay off and user unable to enable it. is this correct?

@nimarezainia,
Looking at elastic/kibana#206074 how the earlier inputs disablement is handled, when users select Agentless, this toggle for Eventhub, thus Microsoft Sentinel Events is not shown to the users.

Screenshot 2025-02-17 at 12 17 17 PM

@kcreddy kcreddy marked this pull request as ready for review March 4, 2025 08:03
@kcreddy
Copy link
Contributor Author

kcreddy commented Mar 4, 2025

@qcorporation, I updated the README as per suggestion from docs team.

azure-eventhub is still present in latest 8.18.0 snapshot. However it is now removed in 9.0.0 and also Serverless.

Azure Eventhub present in latest 8.18.0 Screenshot 2025-03-04 at 1 25 40 PM
Azure Eventhub removed in 9.0.0 Screenshot 2025-03-04 at 1 25 24 PM
Azure Eventhub removed in Serverless Screenshot 2025-03-04 at 1 37 40 PM

It seems that the change removing Eventhub input: elastic/kibana#211262 is merged into 9.0.0 and 9.1.0. Should this be also backported to 8.18.0 or 8.19.0?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kcreddy

@kcreddy
Copy link
Contributor Author

kcreddy commented Mar 5, 2025

Retested after elastic/kibana#213104 in 8.18.0 and the Eventhub input is no longer visible in Agentless mode.

Screenshot 2025-03-05 at 9 14 50 PM

@kcreddy kcreddy merged commit a2ad697 into elastic:main Mar 5, 2025
7 checks passed
@kcreddy kcreddy deleted the sentinel-agentless branch March 5, 2025 16:05
@elastic-vault-github-plugin-prod

Package microsoft_sentinel - 0.5.0 containing this change is available at https://epr.elastic.co/package/microsoft_sentinel/0.5.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:microsoft_sentinel Microsoft Sentinel Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants