[O11y][MySQL] Rally benchmark mysql.slowlog
#9024
Conversation
ali786XI
changed the title
mysql.slowlog
🚀 Benchmarks reportTo see the full report comment with |
| fields: | ||
| - name: timestamp | ||
| period: -24h # one day | ||
| - name: start_time |
There was a problem hiding this comment.
does this mean start time could be after end time? also, should timestamp and start_time be the same?
it would be good if we could generate durations, so we could have the start time, then say we want end times between 100-1000 ms later, for example.
There was a problem hiding this comment.
Thanks @tommyers-elastic for this catch. @aspacca also thanks for your suggestion link.
If we are giving multiple date fields the timestamps would be same which would not make sense. Hence changed the start_time to before 5m and end_time to before 2m the timestamp generated. Let me know if this makes sense.
There was a problem hiding this comment.
perfect, thanks! if these aren't documented we should add something.
only one more comment (not a blocker), could we make these have some variation?
{{- $startTime := generate "timestamp" | date_modify "-5m" }}
{{- $endTime := generate "timestamp" | date_modify "-2m" }}
There was a problem hiding this comment.
@tommyers-elastic Agree. Generated some range of enum values which the start and end time can take.
The date_modify is documented here as a part of this documentation. Is that what you were referring to?
💚 Build Succeeded
History
cc @aliabbas-elastic |
|
|
@tommyers-elastic if all good can we go ahead merging this PR. Let me know if there are any comments. Thanks !! |
Proposed commit message
slowlogdata stream ofMySQLChecklist
How to test this PR locally
Run this command from package root
elastic-package benchmark rally --benchmark slowlog-benchmark -velastic-package benchmark stream --benchmark slowlog-benchmark -vRelated issues
Screenshots