From 09125b642a42a9e1154d564d934518cddabe4659 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Fri, 21 Feb 2025 04:18:03 +1100
Subject: [PATCH] [9.0] [ColorMapping] Fix palette key mapping for legacy
 palette ids (#211858) (#211920)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[ColorMapping] Fix palette key mapping for legacy palette ids
(#211858)](https://github.com/elastic/kibana/pull/211858)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-02-20T15:31:55Z","message":"[ColorMapping]
Fix palette key mapping for legacy palette ids (#211858)\n\nCurrently,
palettes with the legacy palette id of `eui_amsterdam_color_blind`, the
old default id, gets assigned the `kibana 7` palette. The desired
behavior is that this palette is assigned the new borealis default
palette in
`9.0`.","sha":"9e7d93189f6ea59fb21332fd7e0af571a4bac8c0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:version","v9.1.0"],"title":"[ColorMapping]
Fix palette key mapping for legacy palette
ids","number":211858,"url":"https://github.com/elastic/kibana/pull/211858","mergeCommit":{"message":"[ColorMapping]
Fix palette key mapping for legacy palette ids (#211858)\n\nCurrently,
palettes with the legacy palette id of `eui_amsterdam_color_blind`, the
old default id, gets assigned the `kibana 7` palette. The desired
behavior is that this palette is assigned the new borealis default
palette in
`9.0`.","sha":"9e7d93189f6ea59fb21332fd7e0af571a4bac8c0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211858","number":211858,"mergeCommit":{"message":"[ColorMapping]
Fix palette key mapping for legacy palette ids (#211858)\n\nCurrently,
palettes with the legacy palette id of `eui_amsterdam_color_blind`, the
old default id, gets assigned the `kibana 7` palette. The desired
behavior is that this palette is assigned the new borealis default
palette in `9.0`.","sha":"9e7d93189f6ea59fb21332fd7e0af571a4bac8c0"}}]}]
BACKPORT-->

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
---
 src/platform/packages/shared/kbn-palettes/classes/palettes.ts   | 2 +-
 .../shared/kbn-palettes/palettes/categorical/elastic.ts         | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/platform/packages/shared/kbn-palettes/classes/palettes.ts b/src/platform/packages/shared/kbn-palettes/classes/palettes.ts
index 8b0ea42dd0724..00895776007e4 100644
--- a/src/platform/packages/shared/kbn-palettes/classes/palettes.ts
+++ b/src/platform/packages/shared/kbn-palettes/classes/palettes.ts
@@ -37,7 +37,7 @@ export class KbnPalettes {
 function buildAliasMappings(palettes: IKbnPalette[]): Map<string, string> {
   return palettes.reduce((acc, { id, aliases }) => {
     aliases.forEach((alias) => {
-      acc.set(alias, id);
+      if (!acc.has(alias)) acc.set(alias, id);
     });
     return acc;
   }, new Map());
diff --git a/src/platform/packages/shared/kbn-palettes/palettes/categorical/elastic.ts b/src/platform/packages/shared/kbn-palettes/palettes/categorical/elastic.ts
index 0ed2d26d1b939..15c374bf1fd88 100644
--- a/src/platform/packages/shared/kbn-palettes/palettes/categorical/elastic.ts
+++ b/src/platform/packages/shared/kbn-palettes/palettes/categorical/elastic.ts
@@ -20,6 +20,7 @@ export const elasticPalette = new KbnColorFnPalette({
   id: KbnPalette.Default,
   type: 'categorical',
   aliases: [
+    KbnPalette.Default, // needed when switching between new and old themes
     'elastic_borealis', // placeholder - not yet used
     KbnPalette.Amsterdam, // to assign to existing default palettes
   ],