Filter action icons (#64073) (#64167)

* feat: 🎸 add filter icons to filter actions * test: 💍 add unit test for icon type for createFilterAction() * test: 💍 fix TypeScript error
elastic · Apr 22, 2020 · 2a8f6d0 · 2a8f6d0
1 parent a35d220
commit 2a8f6d0
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/src/plugins/data/public/actions/select_range_action.ts b/src/plugins/data/public/actions/select_range_action.ts
@@ -48,6 +48,7 @@ export function selectRangeAction(
   return createAction<typeof ACTION_SELECT_RANGE>({
     type: ACTION_SELECT_RANGE,
     id: ACTION_SELECT_RANGE,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',

diff --git a/src/plugins/data/public/actions/value_click_action.ts b/src/plugins/data/public/actions/value_click_action.ts
@@ -54,6 +54,7 @@ export function valueClickAction(
   return createAction<typeof ACTION_VALUE_CLICK>({
     type: ACTION_VALUE_CLICK,
     id: ACTION_VALUE_CLICK,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',

diff --git a/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts b/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts
@@ -31,6 +31,14 @@ test('has expected display name', () => {
   expect(action.getDisplayName({} as any)).toMatchInlineSnapshot(`"Apply filter to current view"`);
 });
 
+describe('getIconType()', () => {
+  test('returns "filter" icon', async () => {
+    const action = createFilterAction();
+    const result = action.getIconType({} as any);
+    expect(result).toBe('filter');
+  });
+});
+
 describe('isCompatible()', () => {
   test('when embeddable filters and filters exist, returns true', async () => {
     const action = createFilterAction();

diff --git a/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts b/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts
@@ -42,6 +42,7 @@ export function createFilterAction(): ActionByType<typeof ACTION_APPLY_FILTER> {
   return createAction<typeof ACTION_APPLY_FILTER>({
     type: ACTION_APPLY_FILTER,
     id: ACTION_APPLY_FILTER,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('embeddableApi.actions.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',