From 2a8f6d087275c44cb5fac184e89d03cf987fb5b4 Mon Sep 17 00:00:00 2001
From: Vadim Dalecky <streamich@users.noreply.github.com>
Date: Wed, 22 Apr 2020 16:47:17 +0200
Subject: [PATCH] Filter action icons (#64073) (#64167)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* feat: 🎸 add filter icons to filter actions

* test: 💍 add unit test for icon type for createFilterAction()

* test: 💍 fix TypeScript error
---
 src/plugins/data/public/actions/select_range_action.ts    | 1 +
 src/plugins/data/public/actions/value_click_action.ts     | 1 +
 .../public/lib/actions/apply_filter_action.test.ts        | 8 ++++++++
 .../embeddable/public/lib/actions/apply_filter_action.ts  | 1 +
 4 files changed, 11 insertions(+)

diff --git a/src/plugins/data/public/actions/select_range_action.ts b/src/plugins/data/public/actions/select_range_action.ts
index 6e1f16a09e803..ae8d17f942464 100644
--- a/src/plugins/data/public/actions/select_range_action.ts
+++ b/src/plugins/data/public/actions/select_range_action.ts
@@ -48,6 +48,7 @@ export function selectRangeAction(
   return createAction<typeof ACTION_SELECT_RANGE>({
     type: ACTION_SELECT_RANGE,
     id: ACTION_SELECT_RANGE,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',
diff --git a/src/plugins/data/public/actions/value_click_action.ts b/src/plugins/data/public/actions/value_click_action.ts
index 01c32e27da07d..170f776b740a8 100644
--- a/src/plugins/data/public/actions/value_click_action.ts
+++ b/src/plugins/data/public/actions/value_click_action.ts
@@ -54,6 +54,7 @@ export function valueClickAction(
   return createAction<typeof ACTION_VALUE_CLICK>({
     type: ACTION_VALUE_CLICK,
     id: ACTION_VALUE_CLICK,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('data.filter.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',
diff --git a/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts b/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts
index 5297cf6cd365c..636ce3e623c5b 100644
--- a/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts
+++ b/src/plugins/embeddable/public/lib/actions/apply_filter_action.test.ts
@@ -31,6 +31,14 @@ test('has expected display name', () => {
   expect(action.getDisplayName({} as any)).toMatchInlineSnapshot(`"Apply filter to current view"`);
 });
 
+describe('getIconType()', () => {
+  test('returns "filter" icon', async () => {
+    const action = createFilterAction();
+    const result = action.getIconType({} as any);
+    expect(result).toBe('filter');
+  });
+});
+
 describe('isCompatible()', () => {
   test('when embeddable filters and filters exist, returns true', async () => {
     const action = createFilterAction();
diff --git a/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts b/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts
index 4680512fb81c8..1cdb5af00e748 100644
--- a/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts
+++ b/src/plugins/embeddable/public/lib/actions/apply_filter_action.ts
@@ -42,6 +42,7 @@ export function createFilterAction(): ActionByType<typeof ACTION_APPLY_FILTER> {
   return createAction<typeof ACTION_APPLY_FILTER>({
     type: ACTION_APPLY_FILTER,
     id: ACTION_APPLY_FILTER,
+    getIconType: () => 'filter',
     getDisplayName: () => {
       return i18n.translate('embeddableApi.actions.applyFilterActionTitle', {
         defaultMessage: 'Apply filter to current view',