Merge branch 'type-imports-eslint-ro-3' of https://github.com/georgia…

…naonoleata1904/kibana into type-imports-eslint-ro-3

.github/workflows/docs-build.yml

@@ -0,0 +1,22 @@
+name: docs-build
+
+on:
+  push:
+    branches:
+      - main
+  pull_request_target:
+    types:
+      - opened
+      - reopened
+      - synchronize
+
+jobs:
+  docs-preview:
+    uses: elastic/docs-builder/.github/workflows/preview-build.yml@main
+    with:
+      path-pattern: docs/**
+    permissions:
+      deployments: write
+      id-token: write
+      contents: read
+      pull-requests: read

.github/workflows/docs-cleanup.yml

@@ -0,0 +1,14 @@
+name: docs-cleanup
+
+on:
+  pull_request_target:
+    types:
+      - closed
+
+jobs:
+  docs-preview:
+    uses: elastic/docs-builder/.github/workflows/preview-cleanup.yml@main
+    permissions:
+      contents: none
+      id-token: write
+      deployments: write

src/platform/packages/shared/kbn-esql-utils/index.ts

@@ -34,7 +34,6 @@ export {
   isESQLColumnSortable,
   isESQLColumnGroupable,
   isESQLFieldGroupable,
-  TextBasedLanguages,
   sanitazeESQLInput,
   queryCannotBeSampled,
   mapVariableToColumn,

src/platform/packages/shared/kbn-esql-utils/src/index.ts

@@ -7,7 +7,6 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { TextBasedLanguages } from './types';
 export { getESQLAdHocDataview, getIndexForESQLQuery } from './utils/get_esql_adhoc_dataview';
 export { getInitialESQLQuery } from './utils/get_initial_esql_query';
 export { getESQLWithSafeLimit } from './utils/get_esql_with_safe_limit';

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/autocomplete.test.ts

@@ -959,9 +959,10 @@ describe('autocomplete', () => {
           { filterText: '_source', text: '_source, ', command: TRIGGER_SUGGESTION_COMMAND },
         ]);
         // no comma if there are no more fields
-        testSuggestions('FROM a METADATA _id, _ignored, _index, _source, _index_mode, _version/', [
-          { filterText: '_version', text: '_version | ', command: TRIGGER_SUGGESTION_COMMAND },
-        ]);
+        testSuggestions(
+          'FROM a METADATA _id, _ignored, _index, _source, _index_mode, _score, _version/',
+          [{ filterText: '_version', text: '_version | ', command: TRIGGER_SUGGESTION_COMMAND }]
+        );
       });
 
       describe.each(['KEEP', 'DROP'])('%s <field>', (commandName) => {

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/shared/constants.ts

@@ -15,7 +15,15 @@ export const SINGLE_TICK_REGEX = /`/g;
 export const DOUBLE_BACKTICK = '``';
 export const SINGLE_BACKTICK = '`';
 
-export const METADATA_FIELDS = ['_version', '_id', '_index', '_source', '_ignored', '_index_mode'];
+export const METADATA_FIELDS = [
+  '_version',
+  '_id',
+  '_index',
+  '_source',
+  '_ignored',
+  '_index_mode',
+  '_score',
+];
 
 export const FULL_TEXT_SEARCH_FUNCTIONS = ['match', 'match_operator', 'qstr', 'kql'];
 export const UNSUPPORTED_COMMANDS_BEFORE_QSTR = new Set([

src/platform/plugins/shared/discover/public/application/main/components/top_nav/discover_topnav.tsx

@@ -10,8 +10,6 @@
 import React, { useCallback, useEffect, useMemo, useRef } from 'react';
 import { DataViewType } from '@kbn/data-views-plugin/public';
 import type { DataViewPickerProps } from '@kbn/unified-search-plugin/public';
-import { ENABLE_ESQL } from '@kbn/esql-utils';
-import { TextBasedLanguages } from '@kbn/esql-utils';
 import { DiscoverFlyouts, dismissAllFlyoutsExceptFor } from '@kbn/discover-utils';
 import { useSavedSearchInitial } from '../../state_management/discover_state_provider';
 import { ESQL_TRANSITION_MODAL_KEY } from '../../../../../common/constants';
@@ -49,8 +47,7 @@ export const DiscoverTopNav = ({
   onCancelClick,
 }: DiscoverTopNavProps) => {
   const services = useDiscoverServices();
-  const { dataViewEditor, navigation, dataViewFieldEditor, data, uiSettings, setHeaderActionMenu } =
-    services;
+  const { dataViewEditor, navigation, dataViewFieldEditor, data, setHeaderActionMenu } = services;
   const query = useAppStateSelector((state) => state.query);
   const { savedDataViews, managedDataViews, adHocDataViews } =
     useInternalStateSelector(selectDataViewsForPicker);
@@ -174,9 +171,6 @@ export const DiscoverTopNav = ({
   );
 
   const dataViewPickerProps: DataViewPickerProps = useMemo(() => {
-    const isESQLModeEnabled = uiSettings.get(ENABLE_ESQL);
-    const supportedTextBasedLanguages = isESQLModeEnabled ? [TextBasedLanguages.ESQL] : [];
-
     return {
       trigger: {
         label: dataView?.getName() || '',
@@ -188,7 +182,6 @@ export const DiscoverTopNav = ({
       onDataViewCreated: createNewDataView,
       onCreateDefaultAdHocDataView: stateContainer.actions.createAndAppendAdHocDataView,
       onChangeDataView: stateContainer.actions.onChangeDataView,
-      textBasedLanguages: supportedTextBasedLanguages,
       adHocDataViews,
       managedDataViews,
       savedDataViews,
@@ -202,7 +195,6 @@ export const DiscoverTopNav = ({
     managedDataViews,
     savedDataViews,
     stateContainer,
-    uiSettings,
   ]);
 
   const onESQLDocsFlyoutVisibilityChanged = useCallback((isOpen: boolean) => {

src/platform/plugins/shared/unified_search/public/__stories__/search_bar.stories.tsx

@@ -579,7 +579,6 @@ storiesOf('SearchBar', module)
         onChangeDataView: action('onChangeDataView'),
         onAddField: action('onAddField'),
         onDataViewCreated: action('onDataViewCreated'),
-        textBasedLanguages: ['ESQL'],
       },
     } as SearchBarProps)
   )
@@ -595,7 +594,6 @@ storiesOf('SearchBar', module)
         onChangeDataView: action('onChangeDataView'),
         onAddField: action('onAddField'),
         onDataViewCreated: action('onDataViewCreated'),
-        textBasedLanguages: ['ESQL'],
       },
       query: { esql: 'from dataview | project field1, field2' },
     } as unknown as SearchBarProps<Query>)
@@ -612,7 +610,6 @@ storiesOf('SearchBar', module)
         onChangeDataView: action('onChangeDataView'),
         onAddField: action('onAddField'),
         onDataViewCreated: action('onDataViewCreated'),
-        textBasedLanguages: ['ESQL'],
       },
       query: {
         esql: 'from dataview | project field1, field2, field 3, field 4, field 5 | where field5 > 5 | stats var = avg(field3)',
@@ -631,7 +628,6 @@ storiesOf('SearchBar', module)
         onChangeDataView: action('onChangeDataView'),
         onAddField: action('onAddField'),
         onDataViewCreated: action('onDataViewCreated'),
-        textBasedLanguages: ['ESQL'],
       },
       textBasedLanguageModeErrors: [
         new Error(

src/platform/plugins/shared/unified_search/public/dataview_picker/data_view_picker.tsx

@@ -10,7 +10,6 @@
 import React from 'react';
 import type { EuiButtonProps, EuiSelectableProps } from '@elastic/eui';
 import type { DataView, DataViewListItem, DataViewSpec } from '@kbn/data-views-plugin/public';
-import { TextBasedLanguages } from '@kbn/esql-utils';
 import { ChangeDataView } from './change_dataview';
 
 export type ChangeDataViewTriggerProps = EuiButtonProps & {
@@ -69,12 +68,6 @@ export interface DataViewPickerProps {
   onDataViewCreated?: () => void;
 
   onCreateDefaultAdHocDataView?: (dataViewSpec: DataViewSpec) => void;
-  /**
-   * List of the supported text based languages (SQL, ESQL) etc.
-   * Defined per application, if not provided, no text based languages
-   * will be available.
-   */
-  textBasedLanguages?: TextBasedLanguages[];
   /**
    * Makes the picker disabled by disabling the popover trigger
    */
@@ -93,7 +86,6 @@ export const DataViewPicker = ({
   onDataViewCreated,
   trigger,
   selectableProps,
-  textBasedLanguages,
   onCreateDefaultAdHocDataView,
   isDisabled,
 }: DataViewPickerProps) => {
@@ -111,7 +103,6 @@ export const DataViewPicker = ({
       managedDataViews={managedDataViews}
       savedDataViews={savedDataViews}
       selectableProps={selectableProps}
-      textBasedLanguages={textBasedLanguages}
       isDisabled={isDisabled}
     />
   );